vxlan: fix incorrect initializer in union vxlan_addr
authorGerhard Stenzel <gstenzel@linux.vnet.ibm.com>
Fri, 22 Aug 2014 19:34:16 +0000 (21:34 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sat, 23 Aug 2014 02:54:56 +0000 (19:54 -0700)
commita45e92a599e77ee6a850eabdd0141633fde03915
tree36329f9c70cdf5195169fed20ba811293a56a913
parent451fd72219dd6f3355e2d036c598544c760ee532
vxlan: fix incorrect initializer in union vxlan_addr

The first initializer in the following

        union vxlan_addr ipa = {
            .sin.sin_addr.s_addr = tip,
            .sa.sa_family = AF_INET,
        };

is optimised away by the compiler, due to the second initializer,
therefore initialising .sin.sin_addr.s_addr always to 0.
This results in netlink messages indicating a L3 miss never contain the
missed IP address. This was observed with GCC 4.8 and 4.9. I do not know about previous versions.
The problem affects user space programs relying on an IP address being
sent as part of a netlink message indicating a L3 miss.

Changing
            .sa.sa_family = AF_INET,
to
            .sin.sin_family = AF_INET,
fixes the problem.

Signed-off-by: Gerhard Stenzel <gerhard.stenzel@de.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/vxlan.c
This page took 0.027711 seconds and 5 git commands to generate.