USB/PCI/PCMCIA: Clean up new_id and remove_id sysfs attribute routines
authorAlan Stern <stern@rowland.harvard.edu>
Tue, 24 Jan 2012 19:35:13 +0000 (14:35 -0500)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 27 Jan 2012 01:04:39 +0000 (17:04 -0800)
commited283e9f0a2cc0541870828c76c6c6997c51a318
tree60950f46dae4af2cd8648e1c187a198e481904c7
parentfad12ac8c8c2591c7f4e61d19b6a9d76cd49fafa
USB/PCI/PCMCIA: Clean up new_id and remove_id sysfs attribute routines

This patch (as1514) cleans up some places where new_id and remove_id
sysfs attributes are created and deleted.  Handling both attributes in
a single routine rather than a pair of routines makes the code
smaller.  It also prevents certain kinds of errors, like one we
currently have in the USB subsystem: The removeid attribute is often
created even when newid isn't (because the driver's no_dynamid_id flag
is set).

In the case of the PCMCIA subsystem, the newid attribute is created
but never explicitly deleted.  The patch adds a deletion routine.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Acked-by: Dominik Brodowski <linux@dominikbrodowski.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/pci/pci-driver.c
drivers/pcmcia/ds.c
drivers/usb/core/driver.c
This page took 0.025765 seconds and 5 git commands to generate.