pinctrl: mediatek: add missing of_node_put
authorJulia Lawall <Julia.Lawall@lip6.fr>
Mon, 21 Dec 2015 16:39:48 +0000 (17:39 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 22 Dec 2015 12:49:05 +0000 (13:49 +0100)
commit4fc8a4b2a4dd7704d950a01b1afec5e86af60565
tree34d80c8cb8a5d0bdff4ceb0b33fb6da11762521d
parentf7a81b7f4e9830323a7bbee8c4c7ab4c7c7ff6f4
pinctrl: mediatek: add missing of_node_put

for_each_child_of_node performs an of_node_get on each iteration, so a
return from the loop requires an of_node_put.

A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr):

// <smpl>
@@
local idexpression n;
expression e,e1;
@@

 for_each_child_of_node(e1,n) {
   ...
(
   of_node_put(n);
|
   e = n
|
   return n;
|
+  of_node_put(n);
?  return ...;
)
   ...
 }
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/mediatek/pinctrl-mtk-common.c
This page took 0.026392 seconds and 5 git commands to generate.