pwm: ab8500: Fix wrong value shift for disable/enable PWM
authorAxel Lin <axel.lin@ingics.com>
Wed, 9 Apr 2014 13:19:54 +0000 (21:19 +0800)
committerThierry Reding <thierry.reding@gmail.com>
Wed, 21 May 2014 10:29:58 +0000 (12:29 +0200)
commit54b02347d71802a010ceace3dd25ed3774ba8a1e
tree15d3a234708434767ef9005508da5ea85a328f3a
parent3bdf878102110c916dd6a9fb0df9ecfde93a3c83
pwm: ab8500: Fix wrong value shift for disable/enable PWM

Current code only works when pdev->id is 1. Fix it by passing correct
bit values to abx500_mask_and_set_register_interruptible().

Having DISABLE_PWM/ENABLE_PWM does not make the code more readable
because the bit values depend on pdev->id. Thus drop the DISABLE_PWM
and ENABLE_PWM defines.

This patch also removes an unnecessary return in ab8500_pwm_disable().

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Alexandre BOURDIOL <alexandre.bourdiol@st.com>
Acked-by: Philippe Begnic <philippe.begnic@st.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-ab8500.c
This page took 0.026683 seconds and 5 git commands to generate.