cifs: don't return error from standard_receive3 after marking response malformed
authorJeff Layton <jlayton@redhat.com>
Tue, 7 Feb 2012 11:31:05 +0000 (06:31 -0500)
committerSteve French <smfrench@gmail.com>
Wed, 8 Feb 2012 04:25:31 +0000 (22:25 -0600)
commitff4fa4a25a33f92b5653bb43add0c63bea98d464
treecdd46e53bc579250fc0722b2d2f11ff183b47715
parent8b0192a5f478da1c1ae906bf3ffff53f26204f56
cifs: don't return error from standard_receive3 after marking response malformed

standard_receive3 will check the validity of the response from the
server (via checkSMB). It'll pass the result of that check to handle_mid
which will dequeue it and mark it with a status of
MID_RESPONSE_MALFORMED if checkSMB returned an error. At that point,
standard_receive3 will also return an error, which will make the
demultiplex thread skip doing the callback for the mid.

This is wrong -- if we were able to identify the request and the
response is marked malformed, then we want the demultiplex thread to do
the callback. Fix this by making standard_receive3 return 0 in this
situation.

Cc: stable@vger.kernel.org
Reported-and-Tested-by: Mark Moseley <moseleymark@gmail.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <smfrench@gmail.com>
fs/cifs/connect.c
This page took 0.038978 seconds and 5 git commands to generate.