GFS2: Set s_mode before parsing mount options
authorAndrew Price <anprice@redhat.com>
Wed, 23 Sep 2015 13:45:43 +0000 (08:45 -0500)
committerBob Peterson <rpeterso@redhat.com>
Wed, 23 Sep 2015 13:45:43 +0000 (08:45 -0500)
commit6de20eb0dee4c802d9d228d6c08d00386e172e52
tree0cb2d63548aee11bcf8204cedba10eef06b0ede1
parent4b813f09405823dcbb27a434f6ddcd1741e55e9b
GFS2: Set s_mode before parsing mount options

In the generic mount_bdev() function, deactivate_locked_super() is
called after the fill_super() call fails, at which point s_mode has been
set. kill_block_super() expects this and dumps a warning when
FMODE_EXCL is not set in s_mode.

In gfs2_mount() we call deactivate_locked_super() on failure of
gfs2_mount_args(), at which point s_mode has not yet been set. This
causes kill_block_super() to dump a stack trace when gfs2 fails to mount
with invalid options. Set s_mode earlier in gfs2_mount() to avoid that.

Signed-off-by: Andrew Price <anprice@redhat.com>
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
fs/gfs2/ops_fstype.c
This page took 0.02565 seconds and 5 git commands to generate.