xfs: asserting lock not held during freeing not valid
authorDave Chinner <dchinner@redhat.com>
Tue, 24 Sep 2013 06:01:14 +0000 (16:01 +1000)
committerBen Myers <bpm@sgi.com>
Tue, 24 Sep 2013 17:32:57 +0000 (12:32 -0500)
commitb313a5f1cb0bf3276d5457b52b9f75a940e7b5e9
tree141a0a2764099ed5dfb31ea40324433fcfded028
parent4885235806bb95c3fad5a5238e323cb746c3a49b
xfs: asserting lock not held during freeing not valid

When we free an inode, we do so via RCU. As an RCU lookup can occur
at any time before we free an inode, and that lookup takes the inode
flags lock, we cannot safely assert that the flags lock is not held
just before marking it dead and running call_rcu() to free the
inode.

We check on allocation of a new inode structre that the lock is not
held, so we still have protection against locks being leaked and
hence not correctly initialised when allocated out of the slab.
Hence just remove the assert...

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
fs/xfs/xfs_icache.c
This page took 0.024952 seconds and 5 git commands to generate.