rcu: Change function declaration to bool
authorNicholas Mc Guire <hofrat@osadl.org>
Mon, 11 May 2015 16:12:27 +0000 (18:12 +0200)
committerPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Wed, 27 May 2015 19:58:04 +0000 (12:58 -0700)
commit82072c4fcf095ce03a05860365c157c8bb58945b
tree64d9e6afc7d06db1bbebcf9428fc5bac9284a9ad
parentc92fb05795f57463cb763a82f9053d294f77ea87
rcu: Change function declaration to bool

rcu_cpu_has_callbacks() is declared int. The current declaration was introduced
in commit c0f4dfd4f90f (rcu: Make RCU_FAST_NO_HZ take advantage of numbered
callbacks). But it is actually returning bool and as the function description
states " * Return true if the specified CPU has any callback....", this probably
should be a bool as all (3) call-sites currently treat it as bool.

Type-checking coccinelle spatches are being used to locate type mismatches
between function signatures and return values in this case this produced:
./kernel/rcu/tree.c:3538 WARNING: return of wrong type
                    int != bool,

Patch was compile tested with x86_64_defconfig (implies CONFIG_TREE_RCU=y)

Patch is against 4.1-rc3 (localversion-next is -next-20150511) and fixes

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
kernel/rcu/tree.c
This page took 0.027413 seconds and 5 git commands to generate.