Btrfs: device_replace: fix deadlock for nocow case
authorWang Shilong <wangsl.fnst@cn.fujitsu.com>
Wed, 19 Feb 2014 11:24:17 +0000 (19:24 +0800)
committerJosef Bacik <jbacik@fb.com>
Mon, 10 Mar 2014 19:16:53 +0000 (15:16 -0400)
commit12cf93728dfba237b46001a95479829c7179cdc9
treee109418ffb99606add276a2c4a7845881098b147
parent6cf7f77e6ba55cc1469aaf795507d274402892e9
Btrfs: device_replace: fix deadlock for nocow case

commit cb7ab02156e4 cause a following deadlock found by
xfstests,btrfs/011:

Thread1 is commiting transaction which is blocked at
btrfs_scrub_pause().

Thread2 is calling btrfs_file_aio_write() which has held
inode's @i_mutex and commit transaction(blocked because
Thread1 is committing transaction).

Thread3 is copy_nocow_page worker which will also try to
hold inode @i_mutex, so thread3 will wait Thread1 finished.

Thread4 is waiting pending workers finished which will wait
Thread3 finished. So the problem is like this:

Thread1--->Thread4--->Thread3--->Thread2---->Thread1

Deadlock happens! we fix it by letting Thread1 go firstly,
which means we won't block transaction commit while we are
waiting pending workers finished.

Reported-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
Signed-off-by: Wang Shilong <wangsl.fnst@cn.fujitsu.com>
Signed-off-by: Josef Bacik <jbacik@fb.com>
fs/btrfs/scrub.c
This page took 0.027011 seconds and 5 git commands to generate.