Fix: relayd: connection abruptly closed on viewer stream creation failure
authorJérémie Galarneau <jeremie.galarneau@efficios.com>
Wed, 2 Mar 2022 17:59:17 +0000 (12:59 -0500)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Thu, 3 Mar 2022 21:49:35 +0000 (16:49 -0500)
commit14e34907ffbc9645f8ed799b74e04d9c850df4f0
treee2d1cb5e4cb9a3df2587e20a2c58066dd92e02e5
parentfe88e51751c3846b91592a7d52cb975f9c0f5de4
Fix: relayd: connection abruptly closed on viewer stream creation failure

Commit fe88e5175 explains (and fixes) an issue that could cause the
creation of viewer streams to fail. Currently, the error path causes the
relay daemon to abruptly close the connection to its live viewer peer.
This behaviour makes it impossible for the viewer to determine if an
error occurred or if the network connection simply failed.

Returning an `LTTNG_VIEWER_NEW_STREAMS_ERR` status code allows the
viewer to report a precise error. The viewer connection is closed since
the internal error is unlikely to be recoverable.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: I557a8b66c1bd1c0bf361cfbabe962d8a6808f4f4
src/bin/lttng-relayd/live.cpp
This page took 0.026362 seconds and 5 git commands to generate.