ext4: fix COLLAPSE_RANGE test failure in data journalling mode
authorNamjae Jeon <namjae.jeon@samsung.com>
Fri, 11 Apr 2014 02:58:20 +0000 (22:58 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Fri, 11 Apr 2014 02:58:20 +0000 (22:58 -0400)
commit1ce01c4a199c50b023802be25261c0c02b2f0214
tree9a1a94b6b27bf3e959d628552377169240d148ac
parent87f7e41636ff201148443551d06bc74497160aac
ext4: fix COLLAPSE_RANGE test failure in data journalling mode

When mounting ext4 with data=journal option, xfstest shared/002 and
shared/004 are currently failing as checksum computed for testfile
does not match with the checksum computed in other journal modes.
In case of data=journal mode, a call to filemap_write_and_wait_range
will not flush anything to disk as buffers are not marked dirty in
write_end. In collapse range this call is followed by a call to
truncate_pagecache_range. Due to this, when checksum is computed,
a portion of file is re-read from disk which replace valid data with
NULL bytes and hence the reason for the difference in checksum.

Calling ext4_force_commit before filemap_write_and_wait_range solves
the issue as it will mark the buffers dirty during commit transaction
which can be later synced by a call to filemap_write_and_wait_range.

Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
fs/ext4/extents.c
This page took 0.025646 seconds and 5 git commands to generate.