iio: mlx96014: Error checking from positive to negative
authorCrt Mori <cmo@melexis.com>
Fri, 2 Oct 2015 12:24:21 +0000 (14:24 +0200)
committerJonathan Cameron <jic23@kernel.org>
Sat, 3 Oct 2015 09:15:25 +0000 (10:15 +0100)
commit1de953e77b8c8b8cb6f734733cf20e95a1b0fbb8
treea482c774bd4097f91bff9a84f6aa061be16106ff
parentc05dc2cce7422a5c05db470572b22fcd855f8cd7
iio: mlx96014: Error checking from positive to negative

Dan Carpenter reported a static checker report and after his mail I
noticed that we actually return from function if positive value is
obtained from i2c read. This was remainder from when code was not in
separate function (which I changed during the review process).

Static checker reported
  drivers/iio/temperature/mlx90614.c:167
  mlx90614_iir_search()
    warn: this cast is a no-op
which meant that cast before negating is useless. Dan also proposed a
solution on nicer bit operation form.

Also changed magic number to macro in process as that was confusing.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Crt Mori <cmo@melexis.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/iio/temperature/mlx90614.c
This page took 0.024671 seconds and 5 git commands to generate.