vt: Fix replacement console check when unbinding
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 5 Jun 2014 14:24:47 +0000 (16:24 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 6 Jun 2014 20:18:25 +0000 (22:18 +0200)
commit249f7b3e1383d6889889927351b7b018532d2ca1
tree7be4ce3ab68bf5a41ddb6ce0f58f6213af8e0e94
parent8d4ad9d4bb0a618c975a32d77087694ec6336f68
vt: Fix replacement console check when unbinding

I don't fully understand the magic of the vt register/unregister
logic, but apparently everything but the inital console (as set
in the conswitchp pointer) is marked with FLAG_MODULE. Which means
if something unregistered the boot vt driver (e.g. i915.ko kicking
out vga_con) there's nothing left when trying to unbind e.g. fbcon
through sysfs.

But in most cases have the dummy console hanging around besides the
boot console, so this test is fairly dubious. What we actually want is
simply a different console than the one we want to unbind.

v2: Correct the commit message to clarify that the dummy console isn't
always around, but only in most cases (David).

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.cz>
Cc: David Herrmann <dh.herrmann@gmail.com>
Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/tty/vt/vt.c
This page took 0.032567 seconds and 5 git commands to generate.