mmc: card: Fixup request missing in mmc_blk_issue_rw_rq
authorDing Wang <justin.wang@spreadtrum.com>
Mon, 18 May 2015 12:14:15 +0000 (20:14 +0800)
committerUlf Hansson <ulf.hansson@linaro.org>
Tue, 16 Jun 2015 06:58:36 +0000 (08:58 +0200)
commit29535f7b797df35cc9b6b3bca635591cdd3dd2a8
treec09f2eef4aa08d88634eeb0863aa993bc8518273
parent62a7f368ffbc13d9aedfdd7aeae711b177db69ac
mmc: card: Fixup request missing in mmc_blk_issue_rw_rq

The current handler of MMC_BLK_CMD_ERR in mmc_blk_issue_rw_rq function
may cause new coming request permanent missing when the ongoing
request (previoulsy started) complete end.

The problem scenario is as follows:
(1) Request A is ongoing;
(2) Request B arrived, and finally mmc_blk_issue_rw_rq() is called;
(3) Request A encounters the MMC_BLK_CMD_ERR error;
(4) In the error handling of MMC_BLK_CMD_ERR, suppose mmc_blk_cmd_err()
    end request A completed and return zero. Continue the error handling,
    suppose mmc_blk_reset() reset device success;
(5) Continue the execution, while loop completed because variable ret
    is zero now;
(6) Finally, mmc_blk_issue_rw_rq() return without processing request B.

The process related to the missing request may wait that IO request
complete forever, possibly crashing the application or hanging the system.

Fix this issue by starting new request when reset success.

Signed-off-by: Ding Wang <justin.wang@spreadtrum.com>
Fixes: 67716327eec7 ("mmc: block: add eMMC hardware reset support")
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/card/block.c
This page took 0.025025 seconds and 5 git commands to generate.