[SCSI] mpt2sas: Fix possible integer truncation of cpu_count
authorRoland Dreier <roland@purestorage.com>
Thu, 1 Dec 2011 00:30:33 +0000 (16:30 -0800)
committerJames Bottomley <JBottomley@Parallels.com>
Thu, 15 Dec 2011 06:57:40 +0000 (10:57 +0400)
commit2f73b9a896634dd0ce68b5af9ae5f475e24ce51e
tree60c51ea8f5580a6caa8060f32756adfa63ff8d1a
parentc24a1710d18d706ee2bbd87390868242f1a6d8d5
[SCSI] mpt2sas: Fix possible integer truncation of cpu_count

When computing reply_queue_count (the number of MSI-X vectors to use),
the driver does

ioc->reply_queue_count = min_t(u8, ioc->cpu_count,
    ioc->msix_vector_count);

However, on a big machine, ioc->cpu_count could be outside the range
that fits in a u8; eg a system with 256 CPUs will end up
reply_queue_count set to 0.

Fix this by calculating the minimum as ints and then letting the
assignment to reply_queue_count handle integer demotion.

Signed-off-by: Roland Dreier <roland@purestorage.com>
Acked-by: "Nandigama, Nagalakshmi" <Nagalakshmi.Nandigama@lsi.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
drivers/scsi/mpt2sas/mpt2sas_base.c
This page took 0.025184 seconds and 5 git commands to generate.