OMAPDSS: APPLY: print warning if wait_pending_extra_info_updates fails
authorTomi Valkeinen <tomi.valkeinen@ti.com>
Thu, 23 Feb 2012 10:21:09 +0000 (12:21 +0200)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Tue, 6 Mar 2012 12:08:39 +0000 (14:08 +0200)
commit4614679c9d3b77e87b390b6afe8a8dfc980f4387
tree4d329525727de808f6b4dbe25d83451acd9aff5a
parent21e56f79abad987555351c73569fc8358636b0fa
OMAPDSS: APPLY: print warning if wait_pending_extra_info_updates fails

wait_pending_extra_info_updates() currently does a hacky second check
for extra_info_update_ongoing() at the end of the function to show a
warning if extra_info update is still ongoing. The call to
extra_info_update_ongoing() should really be inside spinlock, but that's
a bit heavy just for verification.

Rather than that, check the return value of the
wait_for_completion_timeout() and print an error if it has timeouted or
returned an error.

Even better would be to return the error value and act on it in the
callers of wait_pending_extra_info_updates. However, it's not clear what
the callers should do in case of an error, as the error should only
happen if there's a bug in the driver or the HW. So we'll just print the
warning for now.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/video/omap2/dss/apply.c
This page took 0.025797 seconds and 5 git commands to generate.