fm10k: fix documentation of fm10k_tlv_parse_attr
authorJacob Keller <jacob.e.keller@intel.com>
Fri, 1 Apr 2016 23:17:35 +0000 (16:17 -0700)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Thu, 21 Apr 2016 06:07:31 +0000 (23:07 -0700)
commit4e160f2a59cec8f705583edfaa11ce5f3b3ef4a6
treed189810c62fc41d6fdf752fe46af4f2664ba0451
parent3417415c3a86d6bae8bfee495ce634f4d24e16b8
fm10k: fix documentation of fm10k_tlv_parse_attr

fm10k_tlv_parse_attr is supposed to return FM10K_NOT_IMPLEMENTED for any
TLV who's attribute id lies outside the range of results. It does not do
this today. In addition, the documentation does not indicate that other
attributes which are not implemented for a given TLV will be silently
ignored. Fix this. Clean up the logic so that we don't rely on the fact
that FM10K_NOT_IMPLEMENTED is greater than zero, as this can easily
cause confusion.

A future extension could look into some way of reporting unknown TLVs
in order to make issues more easily discoverable. We can't just return
FM10K_NOT_IMPLEMENTED here because we don't want to drop the entire
message if it has an unknown TLV.

While here, update the copyright year.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Krishneil Singh <Krishneil.k.singh@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/fm10k/fm10k_tlv.c
This page took 0.027131 seconds and 5 git commands to generate.