PCI, AER: Fix severity usage in aer trace event
authorRui Wang <ruiv.wang@gmail.com>
Sun, 8 Dec 2013 04:17:53 +0000 (12:17 +0800)
committerBorislav Petkov <bp@suse.de>
Sun, 8 Dec 2013 14:39:10 +0000 (15:39 +0100)
commit545104dd2ba0feb62544284ee1d6c98fe6ef8245
treee785653c7c11a37048dccb0e0f70fa57a5687580
parent853d9b18f1e861d37e9b271742329f8c1176eabe
PCI, AER: Fix severity usage in aer trace event

There's inconsistency between dmesg and the trace event output.
When dmesg says "severity=Corrected", the trace event says
"severity=Fatal". What happens is that HW_EVENT_ERR_CORRECTED is
defined in edac.h:

enum hw_event_mc_err_type {
        HW_EVENT_ERR_CORRECTED,
        HW_EVENT_ERR_UNCORRECTED,
        HW_EVENT_ERR_FATAL,
        HW_EVENT_ERR_INFO,
};

while aer_print_error() uses aer_error_severity_string[] defined as:

static const char *aer_error_severity_string[] = {
        "Uncorrected (Non-Fatal)",
        "Uncorrected (Fatal)",
        "Corrected"
};

In this case dmesg is correct because info->severity is assigned in
aer_isr_one_error() using the definitions in include/linux/ras.h:

Signed-off-by: Rui Wang <rui.y.wang@intel.com>
Acked-by: Ethan Zhao <ethan.kernel@gmail.com>
Link: http://lkml.kernel.org/r/CANVTcTaP18CiGOSEcX5Ch_wPw9mEhkgokfp+d+ZOMFD+Ce4juA@mail.gmail.com
Signed-off-by: Borislav Petkov <bp@suse.de>
include/trace/events/ras.h
This page took 0.082416 seconds and 5 git commands to generate.