Bluetooth: 6lowpan: Fix memory corruption of ipv6 destination address
authorGlenn Ruben Bakke <glennrubenbakke@nordicsemi.no>
Fri, 22 Apr 2016 16:06:11 +0000 (18:06 +0200)
committerMarcel Holtmann <marcel@holtmann.org>
Mon, 25 Apr 2016 23:08:25 +0000 (01:08 +0200)
commit55441070ca1cbd47ce1ad2959bbf4b47aed9b83b
tree520b1520d798b485a4fafcda388331ac23c65027
parent5c0e03cd9f10d541b69b667a2b1b8980f196f432
Bluetooth: 6lowpan: Fix memory corruption of ipv6 destination address

The memcpy of ipv6 header destination address to the skb control block
(sbk->cb) in header_create() results in currupted memory when bt_xmit()
is issued. The skb->cb is "released" in the return of header_create()
making room for lower layer to minipulate the skb->cb.

The value retrieved in bt_xmit is not persistent across header creation
and sending, and the lower layer will overwrite portions of skb->cb,
making the copied destination address wrong.

The memory corruption will lead to non-working multicast as the first 4
bytes of the copied destination address is replaced by a value that
resolves into a non-multicast prefix.

This fix removes the dependency on the skb control block between header
creation and send, by moving the destination address memcpy to the send
function path (setup_create, which is called from bt_xmit).

Signed-off-by: Glenn Ruben Bakke <glenn.ruben.bakke@nordicsemi.no>
Acked-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Cc: stable@vger.kernel.org # 4.5+
net/bluetooth/6lowpan.c
This page took 0.024387 seconds and 5 git commands to generate.