of: correct of_console_check()'s return value
authorBrian Norris <computersforpeace@gmail.com>
Wed, 3 Sep 2014 18:06:43 +0000 (11:06 -0700)
committerGrant Likely <grant.likely@linaro.org>
Mon, 8 Sep 2014 14:57:24 +0000 (15:57 +0100)
commit5f74d8b7b8546255db6af45b017e9cbb18aed609
treef1dd714d88d5c668c0f38a97d6bf297ac55581f2
parent2ce7598c9a453e0acd0e07be7be3f5eb39608ebd
of: correct of_console_check()'s return value

The comments above of_console_check() say that it will return TRUE if it
registers a preferred console, but add_preferred_console() uses a
0-equals-success convention, so this leaves of_console_check() with an
inconsistent policy for its return values.

Fortunately, nobody was actually checking the return value of
of_console_check(), so this isn't significant at the moment.

But let's match the comments, so we're doing what we say.

Fixes: 3482f2c52b77 ('of: Create of_console_check() for selecting a console specified in /chosen')
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Signed-off-by: Grant Likely <grant.likely@linaro.org>
drivers/of/base.c
This page took 0.027312 seconds and 5 git commands to generate.