Fix: sessiond: notification: missing unlock on client skip
authorJérémie Galarneau <jeremie.galarneau@efficios.com>
Mon, 19 Jul 2021 21:17:39 +0000 (17:17 -0400)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Tue, 20 Jul 2021 19:33:58 +0000 (15:33 -0400)
commit61883fe45e4389fd4fd6ca4c869cc384b4185637
treee5aa614930d65d0dbbaf3f6a9bbc2a8ba5fb15cb
parentc6ee68ae5269d3bcc28c884b17fb42b0e932877f
Fix: sessiond: notification: missing unlock on client skip

Skipping a client must be performed by using the dedicated "skip_client"
label which will unlock the client's lock before continuing the loop
rather than using 'continue' directly.

Currently, a client will remain locked when an hidden trigger emits
a notification to which it is subscribed.

1458230 Missing unlock

May result in deadlock if there is another attempt to acquire the lock.

In notification_client_list_send_evaluation: Missing a release of a lock
on a path (CWE-667)

Reported-by: Coverity Scan
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: I8b69395b91b0ea59ae5e0beadebd9099db623121
src/bin/lttng-sessiond/notification-thread-events.c
This page took 0.026555 seconds and 5 git commands to generate.