GAS: Fix `abort' expansion in write.c
authorMaciej W. Rozycki <macro@imgtec.com>
Tue, 28 Jun 2016 16:33:38 +0000 (17:33 +0100)
committerMaciej W. Rozycki <macro@imgtec.com>
Wed, 29 Jun 2016 00:49:53 +0000 (01:49 +0100)
commit6d44f09a7645d7a2cb2f712c4d2f1f3512e848f5
tree56e0298751b4608e013414796b52e35d6389ae82
parent2fafa20b344ef572d2e1b5002ba9a39e10d1c44c
GAS: Fix `abort' expansion in write.c

Remove an internal diagnostic regression introduced with the inclusion of
"libbfd.h" from write.c, added with:

commit e7ff5c732e7b95aafccd0910ea1a5cb8251a1033
Author: Alan Modra <amodra@gmail.com>
Date:   Fri Feb 16 03:40:17 2007 +0000

That change made "libbfd.h" override the `abort' definition provided by
"as.h" earlier on, making the message produced by any calls reached from
write.c, which is a part of the GAS proper, look like they came from
BFD, e.g.:

.../gas/testsuite/gas/elf/type.s: Assembler messages:
.../gas/testsuite/gas/elf/type.s:30: Error: symbol type "gnu_unique_object" is supported only by GNU targets
../as-new: BFD (GNU Binutils) 2.26.51.20160628 internal error, aborting at .../gas/write.c:608 in size_seg

../as-new: Please report this bug.

vs:

.../gas/testsuite/gas/elf/type.s: Assembler messages:
.../gas/testsuite/gas/elf/type.s:30: Error: symbol type "gnu_unique_object" is supported only by GNU targets
.../gas/testsuite/gas/elf/type.s: Internal error, aborting at .../gas/write.c:602 in size_seg
Please report this bug.

With the removal of "libbfd.h" restore the latter message format.

gas/
* write.c: Remove "libbfd.h" inclusion.
gas/ChangeLog
gas/write.c
This page took 0.026458 seconds and 4 git commands to generate.