srcu: use ACCESS_ONCE() to access sp->completed in srcu_read_lock()
authorLai Jiangshan <laijs@cn.fujitsu.com>
Thu, 29 Nov 2012 08:46:09 +0000 (16:46 +0800)
committerPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Thu, 7 Feb 2013 23:19:36 +0000 (15:19 -0800)
commit7a6b55e7108b3476d13ee9501ec69dbe1605d774
tree9712b0a5f7c3b5d90f2625af369774cdb1334e6f
parent49271ca60645d64197b28c0835fed39f74b1a2d7
srcu: use ACCESS_ONCE() to access sp->completed in srcu_read_lock()

The old SRCU implementation loads sp->completed within an
RCU-sched section, courtesy of preempt_disable().  This was required
due to the use of synchronize_sched() in the old implemenation's
synchronize_srcu().  However, the new implementation does not rely
on synchronize_sched(), so it in turn does not require the load of
sp->completed and the ->c[] counter to be in a single preempt-disabled
region of code.  This commit therefore moves the sp->completed access
outside of the preempt-disabled region and applies ACCESS_ONCE().

The resulting code is almost as the same as before, but it removes the
now-misleading rcu_dereference_index_check() call.

Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
kernel/srcu.c
This page took 0.032693 seconds and 5 git commands to generate.