iio: tsl4531: fix error handling in tsl4531_check_id()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 18 Aug 2015 09:16:33 +0000 (12:16 +0300)
committerJonathan Cameron <jic23@kernel.org>
Mon, 31 Aug 2015 15:29:52 +0000 (16:29 +0100)
commit7d87b3c5c8602df4ce6d615b33ae6dc15438fa29
treebef0bea1b20eaf2bb7818db6f0ec3443bb4b409f
parentaff268cd532e99ced3c8f48d01118912eb002bbf
iio: tsl4531: fix error handling in tsl4531_check_id()

The tsl4531_check_id() function returned 1 on "found" and 0 on "not
found" and negative error codes on failure.  This was non-standard and
bug prone.  The caller treated all non-zero values including error codes
as "found".

This patch fixes it by changing the tsl4531_check_id() to return zero on
success or a negative error code, and updates the caller.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Peter Meerwald <pmeerw@pmeerw.net>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/iio/light/tsl4531.c
This page took 0.025543 seconds and 5 git commands to generate.