net: fec: Ensure that initialization is done prior to request_irq()
authorFabio Estevam <fabio.estevam@freescale.com>
Thu, 21 Feb 2013 09:21:50 +0000 (09:21 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 21 Feb 2013 20:37:49 +0000 (15:37 -0500)
commit7f7d6c282e9d9b1721fdcdeac71383b7b0b60700
treec0e78760d7ba9c788a16cc687ae0aa3dd454e64c
parentb531ed61a2a2a77eeb2f7c88b49aa5ec7d9880d8
net: fec: Ensure that initialization is done prior to request_irq()

Currently request_irq() is called prior to fec_enet_init() and fec_ptp_init(),
which causes the following crash on a mx53qsb:

Unable to handle kernel NULL pointer dereference at virtual address 00000002
pgd = 80004000
[00000002] *pgd=00000000
Internal error: Oops: 5 [#1] SMP ARM
Modules linked in:
CPU: 0    Not tainted  (3.8.0-rc7-next-20130215+ #346)
PC is at fec_enet_interrupt+0xd0/0x348
LR is at fec_enet_interrupt+0xb8/0x348
pc : [<80372b7c>]    lr : [<80372b64>]    psr: 60000193
sp : df855c20  ip : df855c20  fp : df855c74
r10: 00000516  r9 : 1c000000  r8 : 00000000
r7 : 00000000  r6 : 00000000  r5 : 00000000  r4 : df9b7800
r3 : df9b7df4  r2 : 00000000  r1 : 00000000  r0 : df9b7d34

Ensure that such initialization functions are called prior to requesting the
interrupts, so that all necessary the data structures are in place when the
irqs occur.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/fec.c
This page took 0.034794 seconds and 5 git commands to generate.