scsi_netlink: Remove dead and buggy code
authorEric W. Biederman <ebiederm@xmission.com>
Fri, 7 Sep 2012 12:39:21 +0000 (12:39 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 13 Sep 2012 20:26:39 +0000 (16:26 -0400)
commit8289bab1daf9768c20114051a99c1bd5f48d4420
tree8e989dd8f391c49faa1bb63fc5164a44482911ea
parentf05ba7fccf0c5f0422378adaffcb119d08b9f304
scsi_netlink: Remove dead and buggy code

The scsi netlink code confuses the netlink port id with a process id,
going so far as to read NETLINK_CREDS(skb)->pid instead of the correct
NETLINK_CB(skb).pid.  Fortunately it does not matter because nothing
registers to respond to scsi netlink requests.

The only interesting use of the scsi_netlink interface is
fc_host_post_vendor_event which sends a netlink multicast message.

Since nothing registers to handle scsi netlink messages kill all of the
registration logic, while retaining the same error handling behavior
preserving the userspace visible behavior and removing all of the
confused code that thought a netlink port id was a process id.

This was tested with a kernel allyesconfig build which had no problems.

Cc: James Bottomley <James.Bottomley@parallels.com>
Cc: James Smart <James.Smart@Emulex.Com>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/scsi/scsi_netlink.c
include/scsi/scsi_netlink.h
This page took 0.031988 seconds and 5 git commands to generate.