clk: si5351: add missing of_node_put
authorJulia Lawall <Julia.Lawall@lip6.fr>
Wed, 21 Oct 2015 20:41:37 +0000 (22:41 +0200)
committerStephen Boyd <sboyd@codeaurora.org>
Wed, 21 Oct 2015 23:16:33 +0000 (16:16 -0700)
commita1bdfbaf9900a7bafebdba796b034371ee1c3f5e
tree3f0dcac6141d48c42eb5dadf62ce8bdeccf207cc
parent6bc9d9d62cbc885414c7d4bb1926c43950498479
clk: si5351: add missing of_node_put

for_each_child_of_node performs an of_node_get on each iteration, so
a break out of the loop requires an of_node_put.

A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr):

// <smpl>
@@
expression root,e;
local idexpression child;
@@

 for_each_child_of_node(root, child) {
   ... when != of_node_put(child)
       when != e = child
(
   return child;
|
+  of_node_put(child);
?  return ...;
)
   ...
 }
// </smpl>

The resulting puts were manually moved to the end of the function for
conciseness.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
drivers/clk/clk-si5351.c
This page took 0.027211 seconds and 5 git commands to generate.