m68k/atari - ide: do not register interrupt if host->get_lock is set
authorMichael Schmitz <schmitzmic@gmail.com>
Sat, 1 Feb 2014 00:48:13 +0000 (13:48 +1300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 4 Mar 2014 20:58:31 +0000 (15:58 -0500)
commita259d5320537576c0744238f01ca6e75ad776674
treea37cd51c0f9742b06b2cb6b8edfeb01d1b902e98
parent0c0bd34a142963ca3454f530e47ce1c230d8cc9d
m68k/atari - ide: do not register interrupt if host->get_lock is set

On m68k, host->get_lock is used to both lock and register the interrupt
that the IDE host shares with other device drivers. Registering the
IDE interrupt handler in ide-probe.c results in duplicating the
interrupt registered (once via host->get lock, and also via init_irq()),
and may result in IDE accepting interrupts even when another driver has
locked the interrupt hardware. This opens the whole locking scheme up
to races.

host->get_lock is set on m68k only, so other drivers' behaviour is not
changed.

Signed-off-by: Michael Schmitz <schmitz@debian.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: David S. Miller <davem@davemloft.net>
Cc: linux-ide@vger.kernel.org
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/ide/ide-probe.c
This page took 0.024537 seconds and 5 git commands to generate.