eeepc-laptop: check proper return values in get_cpufv
authorFrans Klaver <fransklaver@gmail.com>
Wed, 17 Sep 2014 21:47:26 +0000 (23:47 +0200)
committerDarren Hart <dvhart@linux.intel.com>
Fri, 19 Sep 2014 16:42:11 +0000 (09:42 -0700)
commita5c155b16f4c170d96d41fc6066f245f2d53604d
tree9dee97f27ca749bb850a8766a85e577df22655c0
parent48d4a5b29c8d0cf544ffe96f5855452446b6f20d
eeepc-laptop: check proper return values in get_cpufv

In get_cpufv the return value of get_acpi is stored in the cpufv struct.
Right before this value is checked for errors, it is and'ed with 0xff.
This means c->cur can never be less than zero. Besides that, the actual
error value is ignored.

c->num is also and'ed with 0xff, which means we can ignore values below
zero.

Check the result of get_acpi() right away. While at it, propagate the
error if we got one.

Signed-off-by: Frans Klaver <fransklaver@gmail.com>
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
drivers/platform/x86/eeepc-laptop.c
This page took 0.024203 seconds and 5 git commands to generate.