[PATCH] powerpc: IOMMU SG paranoia
authorJake Moilanen <moilanen@austin.ibm.com>
Tue, 31 Jan 2006 03:51:54 +0000 (21:51 -0600)
committerPaul Mackerras <paulus@samba.org>
Tue, 7 Feb 2006 10:28:38 +0000 (21:28 +1100)
commita958a2648602aaa8f98aeb3c1c914f1b8096bfdc
tree9cb3390ce32ae3292a5bcffe72b0acbab0920957
parentcdc3ee8f2061bafe7593bab0096a0e711408b0f9
[PATCH] powerpc: IOMMU SG paranoia

This addresses two items, which are unlikely to be hit if we
trust drivers.

The first is moving a memory barrier below where the vmerged SG count
is passed back, but before the list is set to end.  If those
instructions were reordered, there could be an issue in iommu_unmap_sg().

The second is making sure we terminate the list on the failure case of
iommu_map_sg().  If a driver does not look at the failure return code,
it could pass a ill-formed SG list to iommu_unmap_sg().

Signed-off-by: Jake Moilanen <moilanen@austin.ibm.com>
Acked-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Paul Mackerras <paulus@samba.org>
arch/powerpc/kernel/iommu.c
This page took 0.024613 seconds and 5 git commands to generate.