char: xillybus: Fix internal data structure initialization
authorEli Billauer <eli.billauer@gmail.com>
Wed, 24 Feb 2016 08:40:51 +0000 (10:40 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 5 Mar 2016 20:19:39 +0000 (12:19 -0800)
commitba327173ef48c12cf6f326441c74f373fa3be220
treed026f0eb8411ea9c98b59271a4a06ebf0c3d5c1e
parenta75fa128236bc2fdaa5e412145cbd577e42e14c2
char: xillybus: Fix internal data structure initialization

A couple of fields in a data structure, which is used by the driver only,
were not initialized properly during the driver's setup.

The primary issue with this bug was that channel->wr_buf_size remained zero,
so calls to dma_sync_single_for_cpu() took place with zero size, and
consequently did nothing.

This had a rather minimal practical impact, because

(a) these calls are NOPs on Intel/AMD platforms, as well as other platforms
    with coherent cache, and
(b) it's extremely rare that any cache line would survive between two reads
    from a given DMA buffer

Hence no significant practical difference is expected with this patch.

Signed-off-by: Eli Billauer <eli.billauer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/char/xillybus/xillybus_core.c
This page took 0.029447 seconds and 5 git commands to generate.