tty: serial: 8250: use 32bit variable for rpm_tx_active
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Mon, 29 Sep 2014 08:21:03 +0000 (10:21 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 30 Sep 2014 01:20:38 +0000 (18:20 -0700)
commitbaeb7ef34952f523a129e5d1369aa42ecbe7f8c9
treef528e8ff4b011c52fb244dd2f26efd1c0ce8e0e3
parent0efe72963409739778e93d8e2046305bc8310e83
tty: serial: 8250: use 32bit variable for rpm_tx_active

The kbuild test robot wrote me:
|  make.cross ARCH=powerpc
|>> ERROR: ".__xchg_called_with_bad_pointer" [drivers/tty/serial/8250/8250.ko] undefined!

The generic implementation of xchg() on arm and x86 works for variables of
size one bye (char). According to the report powerpc does not support
xchg() for one byte sized variables and looking further it seems also to
be the same case for sparc and tile (or for 10 out of 26 architectures
which provide a custom implementation).
For that reason I increase the size of the variable from one to four
bytes to get it work on powerpc (and the others).

Reported-By: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/linux/serial_8250.h
This page took 0.044023 seconds and 5 git commands to generate.