firmware: google memconsole driver fixes
authorMichel Lespinasse <walken@google.com>
Tue, 28 Jan 2014 13:06:22 +0000 (05:06 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 15 Feb 2014 19:30:28 +0000 (11:30 -0800)
commitcb88759107292b4bf36d13c73129add580d4e26e
tree5dfc70e1d1692a705fc35acb48af63c06c6a9867
parentb12b73f1ca7763a94e0949a0d86eea40b5f69ea6
firmware: google memconsole driver fixes

The google memconsole driver is currently broken upstream, as it tries
to read memory that is described as reserved in /proc/iomem, by
dereferencing a pointer obtained through phys_to_virt(). This triggers
a kernel fault as such regions are unmapped after early boot.

The proper workaround is to use ioremap_cache() / iounmap() around such
accesses.

As some unrelated changes, I also converted some printks to use pr_info()
and added some missing __init annotations.

Tested: booted dbg build, verified I could read /sys/firmware/log

Signed-off-by: Michel Lespinasse <walken@google.com>
Acked-by: Mike Waychison <mikew@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/firmware/google/memconsole.c
This page took 0.024611 seconds and 5 git commands to generate.