x86/asm/entry/32: Document the 32-bit SYSENTER "emergency stack" better
authorDenys Vlasenko <dvlasenk@redhat.com>
Mon, 9 Mar 2015 14:52:18 +0000 (15:52 +0100)
committerIngo Molnar <mingo@kernel.org>
Tue, 17 Mar 2015 08:25:29 +0000 (09:25 +0100)
commitd828c71fba8922b116b4ec56c3e5bca8c822d5ae
treee9f6034ed503fcf0f0a8c90ecfe986d5764fb8fa
parent3876488444e71238e287459c39d7692b6f718c3e
x86/asm/entry/32: Document the 32-bit SYSENTER "emergency stack" better

Before the patch, the 'tss_struct::stack' field was not referenced anywhere.

It was used only to set SYSENTER's stack to point after the last byte
of tss_struct, thus the trailing field, stack[64], was used.

But grep would not know it. You can comment it out, compile,
and kernel will even run until an unlucky NMI corrupts
io_bitmap[] (which is also not easily detectable).

This patch changes code so that the purpose and usage of this
field is not mysterious anymore, and can be easily grepped for.

This does change generated code, for a subtle reason:
since tss_struct is ____cacheline_aligned, there happens to be
5 longs of padding at the end. Old code was using the padding
too; new code will strictly use it only for SYSENTER_stack[].

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Alexei Starovoitov <ast@plumgrid.com>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Will Drewry <wad@chromium.org>
Link: http://lkml.kernel.org/r/1425912738-559-2-git-send-email-dvlasenk@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/include/asm/processor.h
arch/x86/kernel/asm-offsets_32.c
arch/x86/kernel/cpu/common.c
This page took 0.055306 seconds and 5 git commands to generate.