ath9k: fix regression in bssidmask calculation
authorBen Greear <greearb@candelatech.com>
Tue, 4 Nov 2014 23:22:50 +0000 (15:22 -0800)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 17 Nov 2014 20:02:52 +0000 (15:02 -0500)
commitdaad1660285a967b5da363e8de264e86b4a496a0
tree62d1899520326fe10a7692bfb8a53d52f1b9315c
parent4e6ce4dc7ce71d0886908d55129d5d6482a27ff9
ath9k: fix regression in bssidmask calculation

The commit that went into 3.17:

    ath9k: Summarize hw state per channel context

    Group and set hw state (opmode, primary_sta, beacon conf) per
    channel context instead of whole list of vifs. This would allow
    each channel context to run in different mode (STA/AP).

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
broke multi-vif configuration due to not properly calculating
the bssid mask.

The test case that caught this was:

 create wlan0 and sta0-4 (6 total), not sure how much that matters.
 associate all 6 (works fine)
 disconnect 5 of them, leaving sta0 up
 Start trying to bring up the other 5 one at a time.  It will
 fail, with iw events looking like this (in these logs, several
 sta are trying to come up, but symptom is the same with just one)

The patch causing the regression made quite a few changes, but
the part I think caused this particular problem was not
recalculating the bssid mask when adding and removing interfaces.

Re-adding those calls fixes my test case.  Fix bad comment
as well.

Signed-off-by: Ben Greear <greearb@candelatech.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/ath/ath9k/main.c
This page took 0.02522 seconds and 5 git commands to generate.