mmc: sunxi: Lock fix
authorDavid Lanzendörfer <david.lanzendoerfer@o2s.ch>
Tue, 16 Dec 2014 14:11:04 +0000 (15:11 +0100)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 19 Jan 2015 08:56:09 +0000 (09:56 +0100)
commitdd9b38039262040c02286b82c413d30b8f0cc6af
treeddfd5db44c466ab453256a638735e1ea85e2b934
parente8a5904945ec4c37e468dfe0ef73418e8e63deef
mmc: sunxi: Lock fix

1) Adding a comment in order to clarify the choice of the locks within
sunxi_mmc_handle_manual_stop

2) As <lixiang@allwinnertech.com> has pointed out the wait_dma variable
was not accessed within the spin lock block in sunxi_mmc_request and so
(even if it should never happend) it would have theoretically been
possible that some other function would access the variable at the same
time as the function. This has been changed now and the function is
using local variables outside the lock and copys the value over during
the lock phase.

Signed-off-by: David Lanzendörfer <david.lanzendoerfer@o2s.ch>
Reported-by: <lixiang@allwinnertech.com>
Acked-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/sunxi-mmc.c
This page took 0.024628 seconds and 5 git commands to generate.