net_sched: fix THROTTLED/RUNNING race
authorEric Dumazet <eric.dumazet@gmail.com>
Thu, 24 Mar 2011 07:13:14 +0000 (00:13 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 24 Mar 2011 07:13:14 +0000 (00:13 -0700)
commitef352e7cdf714596f51ad18809404edeaa50e8fd
tree6323cffca24cba664cd57a7245eb78647c48b914
parent8c64b4cc0201cf05b218ea3271a2abb4f86acb7b
net_sched: fix THROTTLED/RUNNING race

commit fd245a4adb52 (net_sched: move TCQ_F_THROTTLED flag)
added a race.

qdisc_watchdog() is run from softirq, so special care should be taken or
we can lose one state transition (THROTTLED/RUNNING)

Prior to fd245a4adb52, we were manipulating q->flags (qdisc->flags &=
~TCQ_F_THROTTLED;) and this manipulation could only race with
qdisc_warn_nonwc().

Since we want to avoid atomic ops in qdisc fast path - it was the
meaning of commit 371121057607e (QDISC_STATE_RUNNING dont need atomic
bit ops) - fix is to move THROTTLE bit into 'state' field, this one
being manipulated with SMP and IRQ safe operations.

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/sch_generic.h
This page took 0.024729 seconds and 5 git commands to generate.