drm/i915: Don't BUG_ON in i915_gem_obj_offset
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 17 Jun 2014 20:34:38 +0000 (22:34 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 17 Jun 2014 22:48:37 +0000 (00:48 +0200)
commitf25748ea7342bcc44866befcbf0222cd1d89d851
treeaddc91c3b16088a67b6765bda6e7312010de63a6
parent8a270ebf341105b85aaf4f5e4336bb53b3c10177
drm/i915: Don't BUG_ON in i915_gem_obj_offset

A WARN_ON is perfectly fine.

The BUG in here seems to be the cause behind hard-hangs when I cat the
i915_gem_pageflip debugfs file (which calls this from an irq
spinlock). But only while running a full igt run after a while. I
still need to root cause the underlying issue.

I'll also start reject patches which add new BUG_ON but don't come
with a really good justification for it. The general rule really
should be to just WARN and hope the driver survives for long enough.

v2: Make the WARN a bit more useful per Chris' suggestion.

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/i915_gem.c
This page took 0.035179 seconds and 5 git commands to generate.