Check setsockopt arguments to avoid overflows and return -EINVAL for
too large arguments.
Signed-off-by: Xi Wang <xi.wang@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
{
struct sock *sk = sock->sk;
struct nr_sock *nr = nr_sk(sk);
{
struct sock *sk = sock->sk;
struct nr_sock *nr = nr_sk(sk);
if (level != SOL_NETROM)
return -ENOPROTOOPT;
if (level != SOL_NETROM)
return -ENOPROTOOPT;
- if (optlen < sizeof(int))
+ if (optlen < sizeof(unsigned int))
- if (get_user(opt, (int __user *)optval))
+ if (get_user(opt, (unsigned int __user *)optval))
return -EFAULT;
switch (optname) {
case NETROM_T1:
return -EFAULT;
switch (optname) {
case NETROM_T1:
+ if (opt < 1 || opt > ULONG_MAX / HZ)
return -EINVAL;
nr->t1 = opt * HZ;
return 0;
case NETROM_T2:
return -EINVAL;
nr->t1 = opt * HZ;
return 0;
case NETROM_T2:
+ if (opt < 1 || opt > ULONG_MAX / HZ)
return -EINVAL;
nr->t2 = opt * HZ;
return 0;
return -EINVAL;
nr->t2 = opt * HZ;
return 0;
return 0;
case NETROM_T4:
return 0;
case NETROM_T4:
+ if (opt < 1 || opt > ULONG_MAX / HZ)
return -EINVAL;
nr->t4 = opt * HZ;
return 0;
case NETROM_IDLE:
return -EINVAL;
nr->t4 = opt * HZ;
return 0;
case NETROM_IDLE:
+ if (opt > ULONG_MAX / (60 * HZ))
return -EINVAL;
nr->idle = opt * 60 * HZ;
return 0;
return -EINVAL;
nr->idle = opt * 60 * HZ;
return 0;