In these tests, we want to specifically check that the return values are
True or False, not any value that evaluates to True or False.
For example, we initialize can_seek_beginning to None, run
graph.run_once(), then do assertFalse(can_seek_beginning). If, for some
reason, can_seek_beginning is still None, the test will wrongfully pass.
The same could happen if can_seek_beginning gets assigned some value
that evaluates to True (other than True itself) and we use
assertTrue(can_seek_beginning).
Instead, use assertIs, which checks that the value is specifically the
one and only True or the one and only False.
Change-Id: Idf94d350ecc06cdb6a38ca31b2d77804fbf57df7
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed-on: https://review.lttng.org/c/babeltrace/+/2019
Tested-by: jenkins <jenkins@lttng.org>
Reviewed-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Reviewed-by: Philippe Proulx <eeppeliteloop@gmail.com>
input_port_iter_can_seek_beginning = True
can_seek_beginning = None
graph.run_once()
input_port_iter_can_seek_beginning = True
can_seek_beginning = None
graph.run_once()
- self.assertTrue(can_seek_beginning)
+ self.assertIs(can_seek_beginning, True)
input_port_iter_can_seek_beginning = False
can_seek_beginning = None
graph.run_once()
input_port_iter_can_seek_beginning = False
can_seek_beginning = None
graph.run_once()
- self.assertFalse(can_seek_beginning)
+ self.assertIs(can_seek_beginning, False)
def test_no_can_seek_beginning_with_seek_beginning(self):
# Test an iterator without a _user_can_seek_beginning method, but with
def test_no_can_seek_beginning_with_seek_beginning(self):
# Test an iterator without a _user_can_seek_beginning method, but with
graph = _setup_seek_test(MySink, user_seek_beginning=_user_seek_beginning)
can_seek_beginning = None
graph.run_once()
graph = _setup_seek_test(MySink, user_seek_beginning=_user_seek_beginning)
can_seek_beginning = None
graph.run_once()
- self.assertTrue(can_seek_beginning)
+ self.assertIs(can_seek_beginning, True)
def test_no_can_seek_beginning(self):
# Test an iterator without a _user_can_seek_beginning method, without
def test_no_can_seek_beginning(self):
# Test an iterator without a _user_can_seek_beginning method, without
graph = _setup_seek_test(MySink)
can_seek_beginning = None
graph.run_once()
graph = _setup_seek_test(MySink)
can_seek_beginning = None
graph.run_once()
- self.assertFalse(can_seek_beginning)
+ self.assertIs(can_seek_beginning, False)
def test_can_seek_beginning_user_error(self):
class MySink(bt2._UserSinkComponent):
def test_can_seek_beginning_user_error(self):
class MySink(bt2._UserSinkComponent):