If the id of the existed transaction is more than the one we specified, it
means the specified transaction was commited, so we should return 0, not
EINVAL.
Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
Signed-off-by: Chris Mason <chris.mason@fusionio.com>
int btrfs_wait_for_commit(struct btrfs_root *root, u64 transid)
{
struct btrfs_transaction *cur_trans = NULL, *t;
int btrfs_wait_for_commit(struct btrfs_root *root, u64 transid)
{
struct btrfs_transaction *cur_trans = NULL, *t;
if (transid) {
if (transid <= root->fs_info->last_trans_committed)
goto out;
if (transid) {
if (transid <= root->fs_info->last_trans_committed)
goto out;
/* find specified transaction */
spin_lock(&root->fs_info->trans_lock);
list_for_each_entry(t, &root->fs_info->trans_list, list) {
if (t->transid == transid) {
cur_trans = t;
atomic_inc(&cur_trans->use_count);
/* find specified transaction */
spin_lock(&root->fs_info->trans_lock);
list_for_each_entry(t, &root->fs_info->trans_list, list) {
if (t->transid == transid) {
cur_trans = t;
atomic_inc(&cur_trans->use_count);
- if (t->transid > transid)
+ if (t->transid > transid) {
+ ret = 0;
}
spin_unlock(&root->fs_info->trans_lock);
}
spin_unlock(&root->fs_info->trans_lock);
+ /* The specified transaction doesn't exist */
- goto out; /* bad transid */
} else {
/* find newest transaction that is committing | committed */
spin_lock(&root->fs_info->trans_lock);
} else {
/* find newest transaction that is committing | committed */
spin_lock(&root->fs_info->trans_lock);
}
wait_for_commit(root, cur_trans);
}
wait_for_commit(root, cur_trans);
put_transaction(cur_trans);
put_transaction(cur_trans);