The clock is enabled without being prepared, this leads to:
WARNING: CPU: 0 PID: 1 at drivers/clk/clk.c:889 __clk_enable+0x24/0xa8()
and a non working ethernet interface.
Use clk_prepare_enable() and clk_disable_unprepare() to handle the clock.
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
res = PTR_ERR(lp->pclk);
goto err_free_dev;
}
res = PTR_ERR(lp->pclk);
goto err_free_dev;
}
+ clk_prepare_enable(lp->pclk);
lp->hclk = ERR_PTR(-ENOENT);
lp->tx_clk = ERR_PTR(-ENOENT);
lp->hclk = ERR_PTR(-ENOENT);
lp->tx_clk = ERR_PTR(-ENOENT);
err_out_unregister_netdev:
unregister_netdev(dev);
err_disable_clock:
err_out_unregister_netdev:
unregister_netdev(dev);
err_disable_clock:
+ clk_disable_unprepare(lp->pclk);
err_free_dev:
free_netdev(dev);
return res;
err_free_dev:
free_netdev(dev);
return res;
kfree(lp->mii_bus->irq);
mdiobus_free(lp->mii_bus);
unregister_netdev(dev);
kfree(lp->mii_bus->irq);
mdiobus_free(lp->mii_bus);
unregister_netdev(dev);
+ clk_disable_unprepare(lp->pclk);
free_netdev(dev);
return 0;
free_netdev(dev);
return 0;
netif_stop_queue(net_dev);
netif_device_detach(net_dev);
netif_stop_queue(net_dev);
netif_device_detach(net_dev);
+ clk_disable_unprepare(lp->pclk);
struct macb *lp = netdev_priv(net_dev);
if (netif_running(net_dev)) {
struct macb *lp = netdev_priv(net_dev);
if (netif_running(net_dev)) {
+ clk_prepare_enable(lp->pclk);
netif_device_attach(net_dev);
netif_start_queue(net_dev);
netif_device_attach(net_dev);
netif_start_queue(net_dev);