fs: sysfs: return EGBIG on write if offset is larger than file size
authorVladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Wed, 24 Sep 2014 15:21:04 +0000 (18:21 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 7 Nov 2014 18:52:20 +0000 (10:52 -0800)
According to the user expectations common utilities like dd or sh
redirection operator > should work correctly over binary files from
sysfs. At the moment doing excessive write can not be completed:

  write(1, "\0\0\0\0\0\0\0\0", 8)         = 4
  write(1, "\0\0\0\0", 4)                 = 0
  write(1, "\0\0\0\0", 4)                 = 0
  write(1, "\0\0\0\0", 4)                 = 0
  ...

Fix the problem by returning EFBIG described in man 2 write.

Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/sysfs/file.c

index e9ef59b3abb1e5552cdc2a8880df37b85093d249..589abee16a392edf20fadc6bab84f4b9d5789104 100644 (file)
@@ -125,7 +125,7 @@ static ssize_t sysfs_kf_bin_write(struct kernfs_open_file *of, char *buf,
 
        if (size) {
                if (size <= pos)
-                       return 0;
+                       return -EFBIG;
                count = min_t(ssize_t, count, size - pos);
        }
        if (!count)
This page took 0.028183 seconds and 5 git commands to generate.