sunrpc: clean up xdr_shrink_pagelen use of temporary pointer
authorBenny Halevy <bhalevy@panasas.com>
Sun, 29 Aug 2010 16:13:15 +0000 (12:13 -0400)
committerTrond Myklebust <Trond.Myklebust@netapp.com>
Sun, 29 Aug 2010 16:13:15 +0000 (12:13 -0400)
char *p is used only as a shorthand for tail->iov_base + len in a nested
block.  Move it there.

Signed-off-by: Benny Halevy <bhalevy@panasas.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
net/sunrpc/xdr.c

index 91f0de944d0f4a63b506a7438422275dfe366dc2..41be21f7f7b9b0aaf1936825f44ea91927eeb86d 100644 (file)
@@ -395,7 +395,6 @@ xdr_shrink_pagelen(struct xdr_buf *buf, size_t len)
 {
        struct kvec *tail;
        size_t copy;
-       char *p;
        unsigned int pglen = buf->page_len;
 
        tail = buf->tail;
@@ -403,8 +402,8 @@ xdr_shrink_pagelen(struct xdr_buf *buf, size_t len)
 
        /* Shift the tail first */
        if (tail->iov_len != 0) {
-               p = (char *)tail->iov_base + len;
                if (tail->iov_len > len) {
+                       char *p = (char *)tail->iov_base + len;
                        copy = tail->iov_len - len;
                        memmove(p, tail->iov_base, copy);
                }
This page took 0.024884 seconds and 5 git commands to generate.