KVM: PPC: Centralize locking of arch specific vcpu ioctls
authorAvi Kivity <avi@redhat.com>
Thu, 13 May 2010 09:30:43 +0000 (12:30 +0300)
committerAvi Kivity <avi@redhat.com>
Sun, 1 Aug 2010 07:35:48 +0000 (10:35 +0300)
Signed-off-by: Avi Kivity <avi@redhat.com>
arch/powerpc/kvm/powerpc.c

index e0fae7a618ca67da17874278a63aa6b19a49d618..caeed7b31bf922478726c45037e76cec7a71f311 100644 (file)
@@ -512,15 +512,17 @@ long kvm_arch_vcpu_ioctl(struct file *filp,
        void __user *argp = (void __user *)arg;
        long r;
 
-       switch (ioctl) {
-       case KVM_INTERRUPT: {
+       if (ioctl == KVM_INTERRUPT) {
                struct kvm_interrupt irq;
                r = -EFAULT;
                if (copy_from_user(&irq, argp, sizeof(irq)))
-                       goto out;
+                       goto out_nolock;
                r = kvm_vcpu_ioctl_interrupt(vcpu, &irq);
-               break;
+               goto out_nolock;
        }
+
+       vcpu_load(vcpu);
+       switch (ioctl) {
        case KVM_ENABLE_CAP:
        {
                struct kvm_enable_cap cap;
@@ -535,6 +537,8 @@ long kvm_arch_vcpu_ioctl(struct file *filp,
        }
 
 out:
+       vcpu_put(vcpu);
+out_nolock:
        return r;
 }
 
This page took 0.025666 seconds and 5 git commands to generate.