iscsi-target: make some temporary buffers larger
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 24 Jan 2013 07:06:37 +0000 (10:06 +0300)
committerNicholas Bellinger <nab@linux-iscsi.org>
Wed, 13 Feb 2013 19:27:51 +0000 (11:27 -0800)
My static checker complains because we use sprintf() to print some
unsigned ints into 10 byte buffers.  In theory unsigned ints can take 10
characters and we need another for the terminator.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/iscsi/iscsi_target_parameters.c

index d89164287d0045a6aa8cef4a15df78827e58e929..ca2be406f1417c93d7d4652b3850630f8954ac0d 100644 (file)
@@ -1095,11 +1095,11 @@ static int iscsi_check_acceptor_state(struct iscsi_param *param, char *value,
                                SET_PSTATE_REPLY_OPTIONAL(param);
                }
        } else if (IS_TYPE_NUMBER(param)) {
-               char *tmpptr, buf[10];
+               char *tmpptr, buf[11];
                u32 acceptor_value = simple_strtoul(param->value, &tmpptr, 0);
                u32 proposer_value = simple_strtoul(value, &tmpptr, 0);
 
-               memset(buf, 0, 10);
+               memset(buf, 0, sizeof(buf));
 
                if (!strcmp(param->name, MAXCONNECTIONS) ||
                    !strcmp(param->name, MAXBURSTLENGTH) ||
@@ -1503,8 +1503,8 @@ static int iscsi_enforce_integrity_rules(
                        FirstBurstLength = simple_strtoul(param->value,
                                        &tmpptr, 0);
                        if (FirstBurstLength > MaxBurstLength) {
-                               char tmpbuf[10];
-                               memset(tmpbuf, 0, 10);
+                               char tmpbuf[11];
+                               memset(tmpbuf, 0, sizeof(tmpbuf));
                                sprintf(tmpbuf, "%u", MaxBurstLength);
                                if (iscsi_update_param_value(param, tmpbuf))
                                        return -1;
This page took 0.025587 seconds and 5 git commands to generate.