PR26132, ar creates invalid libraries for some targets with plugins enabled

	PR 26132
	* configure.ac: Disable plugins by default for some targets.
	* plugin.c: Comment typo fix.
	* configure: Regenerate.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 6996d040f90a8d09d2a4240da648c42d74398b0d..a77dd705ee064535ca541604e99ff08103818ba5 100644 (file)
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,10 @@
+2020-06-21  Alan Modra  <amodra@gmail.com>
+
+       PR 26132
+       * configure.ac: Disable plugins by default for some targets.
+       * plugin.c: Comment typo fix.
+       * configure: Regenerate.
+
 2020-06-19  Nick Clifton  <nickc@redhat.com>
 
        * plugin.c (try_load_plugin): Suppress the error message about

diff --git a/bfd/configure b/bfd/configure
index 492cbc338ad65e11e6b623455edbba280248983c..c8267514ea744e2862e186d49648d24bfd51c6b6 100755 (executable)
--- a/bfd/configure
+++ b/bfd/configure
@@ -12400,6 +12400,30 @@ fi
 
 
 
+case "${target}" in
+    vax-*-netbsdelf*) ;;
+    *-*-*aout* | i[3-7]86-*-bsd* | i[3-7]86-*-msdos* | ns32k-*-* | \
+    pdp11-*-* | vax-*-*bsd*)
+       if test "$plugins" = "yes"; then
+           if test "${enable_plugins+set}" = set; then
+               { $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: Enabling plugins for AOUT is experimental" >&5
+$as_echo "$as_me: WARNING: Enabling plugins for AOUT is experimental" >&2;}
+           else
+               plugins=no
+           fi
+       fi ;;
+    *-*-*vms* | \
+    powerpc*-*-aix* | powerpc-*-beos* | powerpc-*-macos* | rs6000-*-*)
+       if test "$plugins" = "yes"; then
+           if test "${enable_plugins+set}" = set; then
+               { $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: Enabling plugins may result in ar creating non-standard archives for ${target}" >&5
+$as_echo "$as_me: WARNING: Enabling plugins may result in ar creating non-standard archives for ${target}" >&2;}
+           else
+               plugins=no
+           fi
+       fi ;;
+esac
+
  if test "$plugins" = "yes"; then
   PLUGINS_TRUE=
   PLUGINS_FALSE='#'

diff --git a/bfd/configure.ac b/bfd/configure.ac
index 755633bdd9c40ab033e63010546ca90ad159df6d..1b67cb6caca6cdac2b9fb08c753833461f011638 100644 (file)
--- a/bfd/configure.ac
+++ b/bfd/configure.ac
@@ -44,6 +44,30 @@ LT_INIT([dlopen])
 # AC_PLUGINS setting $plugins is called by ACX_LARGEFILE.
 ACX_LARGEFILE
 
+changequote(,)dnl
+case "${target}" in
+    vax-*-netbsdelf*) ;;
+    *-*-*aout* | i[3-7]86-*-bsd* | i[3-7]86-*-msdos* | ns32k-*-* | \
+    pdp11-*-* | vax-*-*bsd*)
+changequote([,])dnl
+       if test "$plugins" = "yes"; then
+           if test "${enable_plugins+set}" = set; then
+               AC_MSG_WARN(Enabling plugins for AOUT is experimental)
+           else
+               plugins=no
+           fi
+       fi ;;
+    *-*-*vms* | \
+    powerpc*-*-aix* | powerpc-*-beos* | powerpc-*-macos* | rs6000-*-*)
+       if test "$plugins" = "yes"; then
+           if test "${enable_plugins+set}" = set; then
+               AC_MSG_WARN(Enabling plugins may result in ar creating non-standard archives for ${target})
+           else
+               plugins=no
+           fi
+       fi ;;
+esac
+
 AM_CONDITIONAL(PLUGINS, test "$plugins" = "yes")
 
 AC_ARG_ENABLE(64-bit-bfd,

diff --git a/bfd/plugin.c b/bfd/plugin.c
index 5ed87578091403e7bffd5b6634984d9af7b10956..593e277747af6792d18c483539857f36062b08f7 100644 (file)
--- a/bfd/plugin.c
+++ b/bfd/plugin.c
@@ -762,4 +762,4 @@ const bfd_target plugin_vec =
 
   NULL                         /* backend_data.  */
 };
-#endif /* BFD_SUPPORTS_PLUGIN */
+#endif /* BFD_SUPPORTS_PLUGINS */