gpio: da9052: Be sure to clamp return value

As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.

Cc: Ashish Jangam <ashish.jangam@kpitcummins.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

diff --git a/drivers/gpio/gpio-da9052.c b/drivers/gpio/gpio-da9052.c
index 2e9578ec0ca1316381e86f12ea3adae7cc12cbf9..38bd8f122bfc137d1819f1e57360bb0ed83f93ab 100644 (file)
--- a/drivers/gpio/gpio-da9052.c
+++ b/drivers/gpio/gpio-da9052.c
@@ -89,15 +89,12 @@ static int da9052_gpio_get(struct gpio_chip *gc, unsigned offset)
                                              DA9052_STATUS_D_REG);
                if (ret < 0)
                        return ret;
-               if (ret & (1 << DA9052_GPIO_SHIFT_COUNT(offset)))
-                       return 1;
-               else
-                       return 0;
+               return !!(ret & (1 << DA9052_GPIO_SHIFT_COUNT(offset)));
        case DA9052_OUTPUT_PUSHPULL:
                if (da9052_gpio_port_odd(offset))
-                       return ret & DA9052_GPIO_ODD_PORT_MODE;
+                       return !!(ret & DA9052_GPIO_ODD_PORT_MODE);
                else
-                       return ret & DA9052_GPIO_EVEN_PORT_MODE;
+                       return !!(ret & DA9052_GPIO_EVEN_PORT_MODE);
        default:
                return -EINVAL;
        }