mmc: core: Fixed bug in one erase-group budget TRIM
authorRobin van der Gracht <robin@protonic.nl>
Tue, 4 Aug 2015 06:58:33 +0000 (08:58 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Thu, 27 Aug 2015 12:50:47 +0000 (14:50 +0200)
When requesting a trim for several bytes, everything up to the next
erase-group is erased. This causes data corruption.

Signed-off-by: Robin van der Gracht <robin@protonic.nl>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/core/core.c

index 083cade3ffc5d1debd32da28ece75dc79c08f555..57edb2a9bb04bbf52daa9286e90d26ca1341d9b7 100644 (file)
@@ -2227,9 +2227,8 @@ int mmc_erase(struct mmc_card *card, unsigned int from, unsigned int nr,
         * and call mmc_do_erase() twice if necessary. This special case is
         * identified by the card->eg_boundary flag.
         */
-       if ((arg & MMC_TRIM_ARGS) && (card->eg_boundary) &&
-           (from % card->erase_size)) {
-               rem = card->erase_size - (from % card->erase_size);
+       rem = card->erase_size - (from % card->erase_size);
+       if ((arg & MMC_TRIM_ARGS) && (card->eg_boundary) && (nr > rem)) {
                err = mmc_do_erase(card, from, from + rem - 1, arg);
                from += rem;
                if ((err) || (to <= from))
This page took 0.026369 seconds and 5 git commands to generate.