ACPICA: Fix extraneous warning if _DSM returns a package
authorBob Moore <robert.moore@intel.com>
Thu, 3 Sep 2009 01:55:40 +0000 (09:55 +0800)
committerLen Brown <len.brown@intel.com>
Wed, 9 Sep 2009 02:28:33 +0000 (22:28 -0400)
_DSM can return any type of object, so validation on the return
type cannot be performed. ACPICA BZ 802.

http://www.acpica.org/bugzilla/show_bug.cgi?id=802

Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Lin Ming <ming.m.lin@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
drivers/acpi/acpica/nspredef.c

index 8314e6a9e72607ceb9de7fedf28020618075aa00..f8427afeebdfb2017043e753888a9aa8d0250ad7 100644 (file)
@@ -193,11 +193,15 @@ acpi_ns_check_predefined_names(struct acpi_namespace_node *node,
        }
 
        /*
-        * We have a return value, but if one wasn't expected, just exit, this is
+        * 1) We have a return value, but if one wasn't expected, just exit, this is
         * not a problem. For example, if the "Implicit Return" feature is
         * enabled, methods will always return a value.
+        *
+        * 2) If the return value can be of any type, then we cannot perform any
+        * validation, exit.
         */
-       if (!predefined->info.expected_btypes) {
+       if ((!predefined->info.expected_btypes) ||
+           (predefined->info.expected_btypes == ACPI_RTYPE_ALL)) {
                goto cleanup;
        }
 
This page took 0.025668 seconds and 5 git commands to generate.